[Asterisk-code-review] res pjsip callerid: Clear out display name if id->name is n... (asterisk[master])

Richard Mudgett asteriskteam at digium.com
Thu Apr 21 12:02:34 CDT 2016


Richard Mudgett has posted comments on this change.

Change subject: res_pjsip_callerid:  Clear out display name if id->name is not valid
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.asterisk.org/#/c/2653/1/res/res_pjsip_caller_id.c
File res/res_pjsip_caller_id.c:

Line 432: 		pj_strdup2(tdata->pool, &id_name_addr->display, NULL);
Could have used pj_str() or pj_cstr() instead.


-- 
To view, visit https://gerrit.asterisk.org/2653
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I60b4bf7a7ece9b7425eba74151c0b4969cd2738b
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list