[Asterisk-code-review] res pjsip registrar: Fix bad memory-ness with user agent. (asterisk[master])

Joshua Colp asteriskteam at digium.com
Mon Apr 18 17:13:35 CDT 2016


Joshua Colp has posted comments on this change.

Change subject: res_pjsip_registrar: Fix bad memory-ness with user_agent.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/2641/1/res/res_pjsip_registrar.c
File res/res_pjsip_registrar.c:

Line 582: 			ast_sip_location_delete_contact(contact);
You have a reference to the contact itself and it's immutable, so why does it need to be duplicated at all?


-- 
To view, visit https://gerrit.asterisk.org/2641
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cd24c86a38dec69ebcc94150614bc25f46b8c08
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list