[Asterisk-code-review] bridge channel.c: Ignore role setup failure in channel push. (asterisk[master])

George Joseph asteriskteam at digium.com
Sun Apr 17 13:35:40 CDT 2016


George Joseph has posted comments on this change.

Change subject: bridge_channel.c: Ignore role setup failure in channel push.
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/2628/1//COMMIT_MSG
Commit Message:

PS1, Line 15: setup after
Did you mean "setup errors after"?


PS1, Line 17: allocation failure
It wasn't obvious where the "allocation failure" was until I looked in ast_bridge_channel_establish_roles, and there are more reasons ast_bridge_channel_establish_roles can fail other than just the allocation failure.


-- 
To view, visit https://gerrit.asterisk.org/2628
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08a97082b729052ee65cdca6bb730cf1289ede00
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list