[Asterisk-code-review] pjsip: Added "reg server" to contacts. (asterisk[13])
George Joseph
asteriskteam at digium.com
Fri Apr 15 16:36:13 CDT 2016
George Joseph has posted comments on this change.
Change subject: pjsip: Added "reg_server" to contacts.
......................................................................
Patch Set 3: Code-Review-1
(2 comments)
https://gerrit.asterisk.org/#/c/2624/3/contrib/ast-db-manage/config/versions/81b01a191a46_pjsip_add_contact_reg_server.py
File contrib/ast-db-manage/config/versions/81b01a191a46_pjsip_add_contact_reg_server.py:
Line 18: with op.batch_alter_table('ps_contacts') as batch_op:
batch ops weren't supported until alembic 0.7.0 and that version isn't available on all platforms yet.
Also a mix of spaces and tabs for indent.
https://gerrit.asterisk.org/#/c/2624/3/res/res_pjsip/location.c
File res/res_pjsip/location.c:
Line 124: ast_string_field_init_extended(contact, reg_server);
tabs not spaces for indent
--
To view, visit https://gerrit.asterisk.org/2624
To unsubscribe, visit https://gerrit.asterisk.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8f6bd2267809c78753b52bcf21835b9b59f4cb8
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-HasComments: Yes
More information about the asterisk-code-review
mailing list