[Asterisk-code-review] pjsip: Added "reg server" to contacts. (asterisk[13])

George Joseph asteriskteam at digium.com
Fri Apr 15 15:32:39 CDT 2016


George Joseph has posted comments on this change.

Change subject: pjsip: Added "reg_server" to contacts.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/2624/1/include/asterisk/res_pjsip.h
File include/asterisk/res_pjsip.h:

Line 232: 		AST_STRING_FIELD(reg_server);
You can't add a new field here because it will shift the following fields and cause an ABI compatibility issue.

Take a look at the new AST_STRING_FIELD_EXTENDED feature in stringfields.h.


-- 
To view, visit https://gerrit.asterisk.org/2624
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8f6bd2267809c78753b52bcf21835b9b59f4cb8
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list