[Asterisk-code-review] Config: ignore wrong codec name while process allow/disallow... (asterisk[13])

Alexei Gradinari asteriskteam at digium.com
Tue Apr 12 09:24:01 CDT 2016


Alexei Gradinari has posted comments on this change.

Change subject: Config: ignore wrong codec name while process allow/disallow opts.
......................................................................


Patch Set 1:

Old SIP channel ignores wrong codec.
All other channels (ooh323,skinny,iax2,mgcp) ignore wrong codec.

The function ast_format_cap_update_by_allow_disallow doesn't stop processing codec list on issue, it just informs that there is unknown format or bad packetization value.

I think better to log warning then disable endpoint.

-- 
To view, visit https://gerrit.asterisk.org/2573
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I23f5f8bea641ba16e4fc7498d9ba79eab5f4432d
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list