[Asterisk-code-review] Config: ignore wrong codec name while process allow/disallow... (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: Config: ignore wrong codec name while process allow/disallow opts.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/2573/1/main/config_options.c
File main/config_options.c:

Line 735: 			ast_log(LOG_WARNING, "Error parsing %s=%s at line %d of %s, ignoring it\n", var->name, var->value, var->lineno, var->file);
The configuration framework is supposed to intentionally reject invalid configurations.  It thus forces you to fix your invalid configuration rather than glossing over it and you wondering why something doesn't work a month later.

That being said, this is the wrong place to ignore the configuration error anyway.  It needs to be ignored in the opt->handler callback.


-- 
To view, visit https://gerrit.asterisk.org/2573
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I23f5f8bea641ba16e4fc7498d9ba79eab5f4432d
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes