[Asterisk-code-review] res pjsip: Endpoint IP Access Controls (asterisk[13])

[George Joseph]

George Joseph has posted comments on this change.

Change subject: res_pjsip: Endpoint IP Access Controls
......................................................................


Patch Set 2:

> The existing pjsip acl functionality operates on all inbound
 > SIP communication.
 > This patch is able to specify ACL on an endpoint level.

Ok, true.  What's the use case for doing it on an endpoint that can't be satisfied by doing it globally?  Updating the commit message with that info would help folks understand.

Rather than adding the allow/deny fields to endpoint it *might* be better to add an "endpoint" field to acl since acl already has all the plumbing to handle the allow/deny fields.

-- 
To view, visit https://gerrit.asterisk.org/2551
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I456dea3909d929d413864fb347d28578415ebf02
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-HasComments: No