[Asterisk-code-review] res pjsip/AMI: add contact.updated event (asterisk[13])

George Joseph asteriskteam at digium.com
Fri Apr 8 15:35:17 CDT 2016


George Joseph has posted comments on this change.

Change subject: res_pjsip/AMI: add contact.updated event
......................................................................


Patch Set 1:

> if qualify frequency is 0 then in qualify_and_schedule call
 > update_contact_status(contact, UNKNOWN);

So for a brief period of time the state will be still UPDATED.  I'm not sure what the extra state change will do to other things.  Hmmmm.

How about the test suite?  Can you run at least the pjsip tests and see if anything breaks?

-- 
To view, visit https://gerrit.asterisk.org/2556
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8fad8aae9305481469c38d2146e1ba3a56d3108f
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list