[Asterisk-code-review] res pjsip contact: Lock expiration/addition of contacts (asterisk[13])

Richard Mudgett asteriskteam at digium.com
Fri Apr 8 11:59:41 CDT 2016


Richard Mudgett has posted comments on this change.

Change subject: res_pjsip contact:  Lock expiration/addition of contacts
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/2525/3/res/res_pjsip_registrar.c
File res/res_pjsip_registrar.c:

PS3, Line 587: 	if (ast_sip_create_response(task_data->rdata, 200, response_contact, &tdata) != PJ_SUCCESS) {
             : 		ao2_cleanup(response_contact);
             : 		return PJ_TRUE;
             : 	}
Ugh.  You'll need to cleanup contacts here since this is not the original contacts container passed in.


-- 
To view, visit https://gerrit.asterisk.org/2525
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83d413c46a47796f3ab052ca3b349f21cca47059
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list