[Asterisk-code-review] res pjsip: add Useragent and RegExpire to AMI Event ContactS... (asterisk[13])

George Joseph asteriskteam at digium.com
Fri Apr 8 11:23:22 CDT 2016


George Joseph has posted comments on this change.

Change subject: res_pjsip: add Useragent and RegExpire to AMI Event ContactStatus
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/2555/1/res/res_pjsip/pjsip_options.c
File res/res_pjsip/pjsip_options.c:

PS1, Line 1133: 	ast_str_append(&buf, 0, "Useragent: %s\r\n", contact->user_agent);
              : 	ast_str_append(&buf, 0, "RegExpire: %ld\r\n", contact->expiration_time.tv_sec);
Should probably be "UserAgent"

Also these new fields need to be added to the documentation for ContactStatusDetail in res_pjsip.c


-- 
To view, visit https://gerrit.asterisk.org/2555
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If3d121e943e588d016ba51d4eb9c6a421a562239
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list