[Asterisk-code-review] res pjsip outbound publish: Add transport for outbound PUBLISH (asterisk[13])

[George Joseph]

George Joseph has posted comments on this change.

Change subject: res_pjsip_outbound_publish: Add transport for outbound PUBLISH
......................................................................


Patch Set 5: Code-Review-1

(5 comments)

https://gerrit.asterisk.org/#/c/2537/5/res/res_pjsip_outbound_publish.c
File res/res_pjsip_outbound_publish.c:

PS5, Line 90:                                 <configOption name="transport">
            :                                         <synopsis>Transport used for outbound publish</synopsis>
            :                                         <description>
            :                                                 <note><para>A <replaceable>transport</replaceable> configured in
            :                                                 <literal>pjsip.conf</literal>. As with other <literal>res_pjsip</literal> modules, this will use the first available transport of the appropriate type if unconfigured.</para></note>
            :                                         </description>
            :                                 </configOption>
Although the diff doesn't show it, the indent here is spaces and needs to be tabs to mach the rest of the docs.


PS5, Line 127:                 /*! \brief Explicit transport to use for publish */
             :                 AST_STRING_FIELD(transport);
Same


PS5, Line 162:         /*! \brief The name of the transport to be used for the publish */
             :         char *transport_name;
             : };
Same


PS5, Line 345:     		if (!ast_strlen_zero(client->transport_name)) {
             : 			pjsip_tpselector selector = { .type = PJSIP_TPSELECTOR_NONE, };
             :             		ast_sip_set_tpselector_from_transport_name(client->transport_name, &selector);
             :             		pjsip_tx_data_set_transport(tdata, &selector);
             :     		}
this one's a mix of both.


PS5, Line 896:     			if (!ast_strlen_zero(client->transport_name)) {
             : 				pjsip_tpselector selector = { .type = PJSIP_TPSELECTOR_NONE, };
             : 		                ast_sip_set_tpselector_from_transport_name(client->transport_name, &selector);
             :     			        pjsip_tx_data_set_transport(tdata, &selector);
             :     			}
mix of both again.


-- 
To view, visit https://gerrit.asterisk.org/2537
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib389130489b70e36795b0003fa5fd386e2680151
Gerrit-PatchSet: 5
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes