[Asterisk-code-review] res pjsip: Add ability to identify by Authorization username (asterisk[13])

[George Joseph]

George Joseph has posted comments on this change.

Change subject: res_pjsip:  Add ability to identify by Authorization username
......................................................................


Patch Set 14:

(4 comments)

https://gerrit.asterisk.org/#/c/2367/14/configs/samples/pjsip.conf.sample
File configs/samples/pjsip.conf.sample:

Line 927: ;unidentified_request_count=5   ; The number of unidentified requests that can be
> Add a comment that these are only used when auth based username matching is
Done


https://gerrit.asterisk.org/#/c/2367/14/res/res_pjsip.c
File res/res_pjsip.c:

Line 254: 					<description><para>
> Add a comment in here about the implications of using Auth based username m
Done


https://gerrit.asterisk.org/#/c/2367/14/res/res_pjsip/pjsip_distributor.c
File res/res_pjsip/pjsip_distributor.c:

Line 434: 				log_unidentified_request(rdata, unid->count, ms);
> If auth username is not enabled where is this logged?
Oops forgot to copy this to a final "else".


Line 678: 	if (ast_strip(strsep(&io_copy, ","))) {
> How does this guarantee that auth username is in use?
Ha! I forgot to actually check it.  Jet lag.


-- 
To view, visit https://gerrit.asterisk.org/2367
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I30ba62d208e6f63439600916fcd1c08a365ed69d
Gerrit-PatchSet: 14
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes