[Asterisk-code-review] bridge test case: Stop echoing frames once path is confirmed. (testsuite[master])

Joshua Colp asteriskteam at digium.com
Thu Apr 7 16:05:53 CDT 2016


Joshua Colp has uploaded a new change for review.

  https://gerrit.asterisk.org/2552

Change subject: bridge_test_case: Stop echoing frames once path is confirmed.
......................................................................

bridge_test_case: Stop echoing frames once path is confirmed.

This change fixes an issue where DTMF would incorrectly be
echoed back to the sender causing erroneous feature digit failures.
Since these are considered fatal the test would fail.

Now once the media path has been confirmed working the channel
executing Echo() is redirected to a holding extension that merely
waits and does not echo.

Change-Id: I245ebc9bd30335c666b855b9074f119c0d3d7130
---
M configs/bridge/ast3/extensions.conf
M lib/python/asterisk/bridge_test_case.py
2 files changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/testsuite refs/changes/52/2552/1

diff --git a/configs/bridge/ast3/extensions.conf b/configs/bridge/ast3/extensions.conf
index e46b741..d5cee6d 100644
--- a/configs/bridge/ast3/extensions.conf
+++ b/configs/bridge/ast3/extensions.conf
@@ -11,3 +11,7 @@
 same => n,Hangup()
 same => n(fail),UserEvent(DTMF, Success: False)
 same => n,Hangup()
+
+; Holding context for channels
+[holding]
+exten => s,1,Wait(10000)
diff --git a/lib/python/asterisk/bridge_test_case.py b/lib/python/asterisk/bridge_test_case.py
index 9c6fcd8..ea1767e 100644
--- a/lib/python/asterisk/bridge_test_case.py
+++ b/lib/python/asterisk/bridge_test_case.py
@@ -222,6 +222,7 @@
                     bob_connected_line=BridgeTestCase.BOB_CONNECTED,
                     bob_bridge_peer=self.uut_alice_channel,
                     alice_bridge_peer=self.uut_bob_channel)
+                self.ami_bob.redirect(self.bob_channel, "holding", "s", 1)
             else:
                 LOGGER.warning("Audio issues on bridged call")
                 self.set_passed(False)

-- 
To view, visit https://gerrit.asterisk.org/2552
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I245ebc9bd30335c666b855b9074f119c0d3d7130
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Joshua Colp <jcolp at digium.com>



More information about the asterisk-code-review mailing list