[Asterisk-code-review] app voicemail/IMAP: IMAP access FATAL error: Out of memory (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: app_voicemail/IMAP: IMAP access FATAL error: Out of memory
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

This should be cherry picked to 11 and master as well.

https://gerrit.asterisk.org/#/c/2545/1//COMMIT_MSG
Commit Message:

Line 17: 
The ASTERISK issue should be in the commit message as well.


https://gerrit.asterisk.org/#/c/2545/1/apps/app_voicemail.c
File apps/app_voicemail.c:

Line 583: #define MAX_MAIL_BODY_CONTENT_SIZE 134217728L // 128 Mbyte
Where did this value come from? Is there a more reasonable one?


Line 3636: 	len=newlen=0;
Normally these are just set to zero when declared above instead of doing it like this.


-- 
To view, visit https://gerrit.asterisk.org/2545
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a0e7d655f11abef6a5224e2169df6d5c1f1caca
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes