[Asterisk-code-review] res pjsip registrar expire: Fix race condition at shutdown. (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: res_pjsip_registrar_expire: Fix race condition at shutdown.
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/2543/2//COMMIT_MSG
Commit Message:

Line 9: When shutting down the PJSIP sorcery is destroyed. The registrar
s/down the/down, the/


https://gerrit.asterisk.org/#/c/2543/2/res/res_pjsip_registrar_expire.c
File res/res_pjsip_registrar_expire.c:

PS2, Line 92: 		if (check_thread != AST_PTHREADT_NULL) {
            : 			pthread_kill(check_thread, SIGURG);
            : 			check_thread = AST_PTHREADT_NULL;
            : 			ast_debug(3, "Interval = 0, shutting thread down\n");
Need to join here too or we leak the thread memory.


-- 
To view, visit https://gerrit.asterisk.org/2543
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I69fd239edbaaf160c2d37ae00d3ac06e5596fe8b
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes