[Asterisk-code-review] res pjsip outbound publish: add transport for outbound PUBLISH (asterisk[13])

Joshua Colp asteriskteam at digium.com
Thu Apr 7 11:22:00 CDT 2016


Joshua Colp has posted comments on this change.

Change subject: res_pjsip_outbound_publish: add transport for outbound PUBLISH
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

This should have an ASTERISK issue created for it so it can be associated. The CHANGES file also needs to be updated to make note that the transport can now be set on outbound publishes. Once that's done this can also be cherry picked into master.

https://gerrit.asterisk.org/#/c/2537/1/res/res_pjsip_outbound_publish.c
File res/res_pjsip_outbound_publish.c:

Line 346:     		if (!ast_strlen_zero(client->transport_name)) {
You can move the pjsip_tpselector in here, stuff these days follows the scope where it is used.


Line 588: 		ast_sip_set_tpselector_from_transport_name(client->transport_name, &selector);
Same here.


-- 
To view, visit https://gerrit.asterisk.org/2537
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib389130489b70e36795b0003fa5fd386e2680151
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list