[Asterisk-code-review] app chanspy: reduce audio loss on the spying channel. (asterisk[master])

Joshua Colp asteriskteam at digium.com
Tue Apr 5 11:56:37 CDT 2016


Joshua Colp has posted comments on this change.

Change subject: app_chanspy: reduce audio loss on the spying channel.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

Using the explanation from my question a CHANGES entry should be created with details of the added option and when it should be used.

https://gerrit.asterisk.org/#/c/2520/1//COMMIT_MSG
Commit Message:

PS1, Line 10: and AST_AUDIOHOOK_SMALL_QUEUE, which caused audio frames to be lost in some
            : cases. Now these flags are set conditionally:
Can you elaborate on the cases where this was happening?


-- 
To view, visit https://gerrit.asterisk.org/2520
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c7652f41d9fa72c8691e4e70ec4fd16b047a4dd
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Jean Aunis - Prescom <jean.aunis at prescom.fr>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list