[Asterisk-code-review] config: Allow filters when appending to a category (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: config:  Allow filters when appending to a category
......................................................................


Patch Set 2: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/#/c/2487/2/include/asterisk/config.h
File include/asterisk/config.h:

Line 410: struct ast_category *ast_category_get_sep(const struct ast_config *config,
I don't think this should be made public.  At least not with this patch since there is no one outside of this module that needs it.


https://gerrit.asterisk.org/#/c/2487/2/include/asterisk/strings.h
File include/asterisk/strings.h:

Line 322: char *ast_strsep2(char **s, const char *sep, uint32_t flags);
Left over change no longer needed.  This needs to be reverted.


https://gerrit.asterisk.org/#/c/2487/2/main/config.c
File main/config.c:

PS2, Line 987: struct ast_category *ast_category_get_sep(const struct ast_config *config,
             : 	const char *category_name, const char *filter, const char sep)
             : {
make static.  There is nobody outside this module that needs the function at this time.


-- 
To view, visit https://gerrit.asterisk.org/2487
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I10773da4c79db36fbf1993961992af63d3441580
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes