[Asterisk-code-review] pbx: Add support for autohints. (asterisk[master])

[Matt Jordan]

Matt Jordan has posted comments on this change.

Change subject: pbx: Add support for autohints.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/2499/1/main/pbx.c
File main/pbx.c:

Line 3590: 	/* We only want actual devices for autohint functionality */
> It creates extremely weirdly named hints as there are some very creative on
The only reason I can think of to not allow this is that it could conceivably explode the number of autohints created, and/or generate a lot of hints that I might not care about. I'm not sure if that's a reason to disallow virtual device changes.


-- 
To view, visit https://gerrit.asterisk.org/2499
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7e444c7da41b7b7d33374420fec658beeb18584e
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-HasComments: Yes