[Asterisk-code-review] res rtp asterisk: Move "Set role" warning to be debug. (asterisk[11])

Joshua Colp asteriskteam at digium.com
Wed Sep 30 14:06:54 CDT 2015


Joshua Colp has posted comments on this change.

Change subject: res_rtp_asterisk: Move "Set role" warning to be debug.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/1346/1/res/res_rtp_asterisk.c
File res/res_rtp_asterisk.c:

Line 799: if
> This 'if' must be the first statement. It will be more fast without ICE.
If debug is not on then both of these will do nothing. If debug is on then being fast is not something I would think you would care about. I would also say it's a bit easier to debug things if you know what role the ICE instance was going to be set to.


-- 
To view, visit https://gerrit.asterisk.org/1346
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0e17e4316f0f0d7f095c78c3d4fd73a913b6ba69
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 11
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: ibercom <ibercom123 at gmail.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list