[Asterisk-code-review] sched.c: Add warning about negative time interval request. (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: sched.c: Add warning about negative time interval request.
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.asterisk.org/#/c/1344/1/main/sched.c
File main/sched.c:

Line 458: 		ast_log(LOG_WARNING,
> While we're here, how about an assert?
Yeah, an assert should be here.


Line 459: 			"Bug likely: Negative time interval %d (interpreted as %u ms) requested!\n",
        : 			when, (unsigned int) when);
> If this were logged out, how would we debug what occurred?
This warning is just an indication that something not good is happening.  How to debug would need to be determined by which user of the scheduler is involved.


-- 
To view, visit https://gerrit.asterisk.org/1344
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib91435fb45b7f5f7c0fc83d0eec20b88098707bc
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes