[Asterisk-code-review] StatsD: Create a mock StatsD server in the Testsuite (testsuite[master])

Ashley Sanders asteriskteam at digium.com
Mon Sep 28 13:17:11 CDT 2015


Ashley Sanders has posted comments on this change.

Change subject: StatsD: Create a mock StatsD server in the Testsuite
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/1313/2/tests/apps/statsd/nominal/mockd.py
File tests/apps/statsd/nominal/mockd.py:

Line 73:     def __on_ami_connect(self, ami):
       :         ''' AMI connected handler
       : 
       :         :param The AMI instance that just connected
       :         '''
       :         LOGGER.debug('AMI instance %s Connected' % ami)
> I think the intent was to use the ami_connect observer to then start the se
Nevermind, I see reactor.listenUDP in the __init__ method now. It was being obscured by a review comment.


-- 
To view, visit https://gerrit.asterisk.org/1313
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4eaf92465b79569fff4db6ada16e8d215f7d214b
Gerrit-PatchSet: 2
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Tyler Cambron <tcambron at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list