[Asterisk-code-review] channel.c: Fix NewCallerid AMI event not been sent on Caller... (asterisk[11])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: channel.c: Fix NewCallerid AMI event not been sent on Caller ID change
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

This patch also needs to be cherry picked to 13 and master.

https://gerrit.asterisk.org/#/c/1334/1//COMMIT_MSG
Commit Message:

Line 11: may use the same memory, so pointers match, while the contect
s/contect/content/


https://gerrit.asterisk.org/#/c/1334/1/main/channel.c
File main/channel.c:

Line 7403: 				ast_strdupa(ast_channel_caller(chan)->id.number.str), "");
         : 	old_name = S_COR(ast_channel_caller(chan)->id.name.valid,
         : 				ast_strdupa(ast_channel_caller(chan)->id.name.str), "");
Please indent one level for line continuation.


Line 7410: 				ast_channel_caller(chan)->id.number.str, "");
         : 	new_name = S_COR(ast_channel_caller(chan)->id.name.valid,
         : 				ast_channel_caller(chan)->id.name.str, "");
same


-- 
To view, visit https://gerrit.asterisk.org/1334
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2a1ac3a842f0e092c6058d1cd3e35443bece1b36
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 11
Gerrit-Owner: Ivan Poddubny <ivan.poddubny at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes