[Asterisk-code-review] pjsip rls large notify test - fails to send notify due (testsuite[master])

Kevin Harwell asteriskteam at digium.com
Fri Sep 25 12:40:05 CDT 2015


Kevin Harwell has uploaded a new patch set (#2).

Change subject: pjsip rls large notify test - fails to send notify due
......................................................................

pjsip rls large notify test - fails to send notify due

This test, configured to use a TCP transport, was not sending the notify
because of an unsupported transport error. What's happening was there was no
transport associated with the contact, so it would default to use UDP and then
fail because the pjsip option "disable_tcp_switch" defaults to yes (so UDP->
TCP auto-change would not occur). Adding a transport parameter to the contact
header ensures the use of the correct transport.

Also, even though this test failed to send the notify it was still passing
because the test simply timed out with no failure condition. To fix this a
failure condition was also added that checks to make sure a particular event
is received, and if it isn't then it will fail.

ASTERISK-25363

Change-Id: I1a61a7efd72bfe8681b684510433b57df7b9c5a8
---
M tests/channels/pjsip/subscriptions/rls/lists/off_nominal/large_notify/sipp/subscribe.xml
M tests/channels/pjsip/subscriptions/rls/lists/off_nominal/large_notify/test-config.yaml
2 files changed, 20 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.asterisk.org:29418/testsuite refs/changes/14/1314/2
-- 
To view, visit https://gerrit.asterisk.org/1314
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1a61a7efd72bfe8681b684510433b57df7b9c5a8
Gerrit-PatchSet: 2
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>



More information about the asterisk-code-review mailing list