[Asterisk-code-review] res/res rtp asterisk: Ensure ICE support is enabled before l... (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: res/res_rtp_asterisk: Ensure ICE support is enabled before logging a warning.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/1310/1/res/res_rtp_asterisk.c
File res/res_rtp_asterisk.c:

Line 803: 			ast_log(LOG_WARNING, "Set role failed; no ice instance (%p)\n", instance);
I'm not sure this really solves all the problems. If ICE support is enabled but a channel driver explicitly disables it then rtp->ice will be NULL and icesupport will be set. The warning message will then be output even though it's perfectly fine. I think either we need the ability to see if it's been explicitly disabled or the message should be downgraded to debug.


-- 
To view, visit https://gerrit.asterisk.org/1310
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I04b2bf5b29f0a0e21c9db33cbcea89e11dfd6f6c
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Elazar Broad <elazar at thebroadfamily.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes