[Asterisk-code-review] res/res rtp asterisk Ensure ICE support is enabled before lo... (asterisk[master])

Elazar Broad asteriskteam at digium.com
Thu Sep 24 16:49:59 CDT 2015


Elazar Broad has uploaded a new change for review.

  https://gerrit.asterisk.org/1309

Change subject: res/res_rtp_asterisk Ensure ICE support is enabled before logging a warning.
......................................................................

res/res_rtp_asterisk
Ensure ICE support is enabled before logging a warning.

Commit 8e5ed27 added additional debug logging logic for ICE.
One of these statements will issue a warning regardless
if ICE is enabled or not in rtp.conf. This commit resolves
that.

Change-Id: Ifa0c2c58a962beedcbd0cb1fe4efe1202212e860
---
M res/res_rtp_asterisk.c
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/09/1309/1

diff --git a/res/res_rtp_asterisk.c b/res/res_rtp_asterisk.c
index a51e07c..b7d9d3d 100644
--- a/res/res_rtp_asterisk.c
+++ b/res/res_rtp_asterisk.c
@@ -798,7 +798,7 @@
 	ast_debug(3, "Set role to %s (%p)\n",
 		role == AST_RTP_ICE_ROLE_CONTROLLED ? "CONTROLLED" : "CONTROLLING", instance);
 
-	if (!rtp->ice) {
+	if (icesupport & !rtp->ice) {
 		ast_log(LOG_WARNING, "Set role failed; no ice instance (%p)\n", instance);
 		return;
 	}

-- 
To view, visit https://gerrit.asterisk.org/1309
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifa0c2c58a962beedcbd0cb1fe4efe1202212e860
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Elazar Broad <elazar at thebroadfamily.com>



More information about the asterisk-code-review mailing list