[Asterisk-code-review] logger: Prevent duplicate dynamic channels from being added. (asterisk[13])

Mark Michelson asteriskteam at digium.com
Thu Sep 24 15:04:03 CDT 2015


Mark Michelson has posted comments on this change.

Change subject: logger: Prevent duplicate dynamic channels from being added.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/1303/1/main/logger.c
File main/logger.c:

Line 308: 		ast_copy_string(filename, channel, size);
> Shouldn't this return afterwards?
Yep, good call.


-- 
To view, visit https://gerrit.asterisk.org/1303
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I892d52954d6007d8bc453c3cbdd9235dec9c4a36
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list