[Asterisk-code-review] CHAOS: avoid crash if string create fails (asterisk[master])

Richard Mudgett asteriskteam at digium.com
Fri Sep 18 11:31:37 CDT 2015


Richard Mudgett has posted comments on this change.

Change subject: CHAOS: avoid crash if string create fails
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/1278/2/res/res_config_sqlite.c
File res/res_config_sqlite.c:

Line 785: 		if (sql1) {
        : 			ast_free(sql1);
        : 		}
        : 		if (sql2) {
        : 			ast_free(sql2);
        : 		}
ast_free is NULL tolerant so you don't need to check for NULL before calling.


-- 
To view, visit https://gerrit.asterisk.org/1278
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9c338bdc1e53fb8b81366f0b39482b83ef56ce0
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Scott Griepentrog <sgriepentrog at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list