[Asterisk-code-review] app queue: Test blind and attended transfers with queues (testsuite[master])

[Kevin Harwell]

Kevin Harwell has posted comments on this change.

Change subject: app_queue: Test blind and attended transfers with queues
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.asterisk.org/#/c/1274/1/tests/apps/queues/transfer/caller_attended/test-config.yaml
File tests/apps/queues/transfer/caller_attended/test-config.yaml:

Line 100:             conditions:
        :                 match:
        :                     Event: 'VarSet'
        :                     Variable: BRIDGEPEER
        :                     Channel: 'PJSIP/alice-.*'
        :                     Value: 'PJSIP/charlie-.*'
        :             count: '3'
        :             conditions:
        :                 match:
        :                     Event: 'VarSet'
        :                     Variable: BRIDGEPEER
        :                     Channel: 'PJSIP/charlie-.*'
        :                     Value: 'PJSIP/alice-.*'
        :             count: '3'
> The values duplicated here (I believe) result in only one set of conditions
The two sets of conditions are not duplicated (if that's what you mean). The 'Channel' and 'Value' parameters are swapped.

In this case, once the count is met (doesn't matter which one I only care that they are bridged) I want it to execute the transfer. I probably only need one set of conditions. If you feel strongly that I should change it I will.


Line 122:             conditions:
        :                 match:
        :                     Event: 'AttendedTransfer'
        :                     OrigTransfererChannel: 'PJSIP/alice-.*'
        :                     SecondTransfererChannel: 'PJSIP/alice-.*'
        :                     TransfereeChannel: 'PJSIP/bob-.*'
        :                     TransferTargetChannel: 'PJSIP/charlie-.*'
        :                     Result: 'Success'
        :             count: 1
        :             conditions:
        :                 match:
        :                     Event: 'AgentComplete'
        :                     Channel: 'PJSIP/alice-.*'
        :                     MemberName: 'PJSIP/bob'
        :                     Reason: 'transfer'
        :             count: 1
> Duplicated
I don't understand. Did you mean these two conditions are copies of each other or are you saying, "same as above comment"?

If the former, they are different events. If the latter then I am only trying to match and make sure these events have been raised appropriately. They trigger no execution context.


https://gerrit.asterisk.org/#/c/1274/1/tests/apps/queues/transfer/caller_blind/test-config.yaml
File tests/apps/queues/transfer/caller_blind/test-config.yaml:

Line 100:             conditions:
        :                 match:
        :                     Event: 'BlindTransfer'
        :                     TransfererChannel: 'PJSIP/alice-.*'
        :                     TransfereeChannel: 'PJSIP/bob-.*'
        :                     Extension: '102'
        :                     Result: 'Success'
        :             count: 1
        :             conditions:
        :                 match:
        :                     Event: 'AgentComplete'
        :                     Channel: 'PJSIP/alice-.*'
        :                     MemberName: 'PJSIP/bob'
        :                     Reason: 'transfer'
        :             count: 1
> duplicated values
What do you mean by duplicate values? These are two different conditions being checked and I don't see those conditions anywhere else in the file.


-- 
To view, visit https://gerrit.asterisk.org/1274
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I359ce622f4be04c1af7e10a41a39425b6674ea03
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Scott Griepentrog <sgriepentrog at digium.com>
Gerrit-HasComments: Yes