[Asterisk-code-review] CHAOS: avoid crash if string create fails (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: CHAOS: avoid crash if string create fails
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/1278/1/res/res_config_sqlite.c
File res/res_config_sqlite.c:

Line 784: 	if (!tbl) {
        : 		ast_log(LOG_WARNING, "No such table: %s\n", cdr_table);
        : 		return -1;
        : 	}
Memory leak: Need to ast_free sql1 and sql2 before return.


Line 789: 	if (!sql1 || !sql2) {
        : 		return -1;
        : 	}
Memory leak: Need to ast_free sql1 and sql2 before return.


-- 
To view, visit https://gerrit.asterisk.org/1278
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9c338bdc1e53fb8b81366f0b39482b83ef56ce0
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Scott Griepentrog <sgriepentrog at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes