[Asterisk-code-review] pbx: Update device and presence state when changing a hint e... (asterisk[11])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: pbx: Update device and presence state when changing a hint extension.
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.asterisk.org/#/c/1262/1/main/pbx.c
File main/pbx.c:

Line 5997: 	char *message = NULL, *subtype = NULL;
NIT: One declaration per line.  Lines are cheap.


Line 6030: 	if ((presence_state = extension_presence_state_helper(ne, &subtype, &message)) > 0) {
> Could calling extension_presence_state_helper() with the hints container lo
NIT: There is no need to keep putting the assignment inside the if test.  It just makes reading the code harder and makes line continuations harder to figure out.


-- 
To view, visit https://gerrit.asterisk.org/1262
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If268f1110290e502c73dd289c9e7e7b27bc8432f
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 11
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes