[Asterisk-code-review] scheduler: Use stack for allocating sched IDs. (asterisk[certified/13.1])

Richard Mudgett asteriskteam at digium.com
Tue Sep 15 11:52:12 CDT 2015


Richard Mudgett has posted comments on this change.

Change subject: scheduler: Use stack for allocating sched IDs.
......................................................................


Patch Set 3: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/#/c/1257/3//COMMIT_MSG
Commit Message:

Line 7: scheduler: Use stack for allocating sched IDs.
This is now a free sched id queue instead of a stack.

The rest of the message should reflect this as well.


https://gerrit.asterisk.org/#/c/1257/3/main/sched.c
File main/sched.c:

Line 316: 			continue;
This should be a break because a continue could have you wind up with holes in the allocated ids when i is incremented without actually being allocated.


Line 338: 
NIT: Extraneous blank line.


-- 
To view, visit https://gerrit.asterisk.org/1257
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I532708eef8f669d823457d7fefdad9a6078b99b2
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: certified/13.1
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list