[Asterisk-code-review] scheduler: Use stack for allocating sched IDs. (asterisk[certified/13.1])

Mark Michelson asteriskteam at digium.com
Tue Sep 15 09:59:53 CDT 2015


Mark Michelson has posted comments on this change.

Change subject: scheduler: Use stack for allocating sched IDs.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/1257/1/main/sched.c
File main/sched.c:

Line 244: 	ast_free(task->sched_id);
> This should be an ast_assert(task->sched_id == NULL) because there should n
The task->sched_id can be non-NULL when destroying the scheduler context. The scheduler context iterates over the heap and destroys all scheduled tasks.


-- 
To view, visit https://gerrit.asterisk.org/1257
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I532708eef8f669d823457d7fefdad9a6078b99b2
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: certified/13.1
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list