[Asterisk-code-review] main/config options: Check for existance of internal object ... (asterisk[13])

Ashley Sanders asteriskteam at digium.com
Mon Sep 14 20:53:10 CDT 2015


Ashley Sanders has posted comments on this change.

Change subject: main/config_options: Check for existance of internal object before derefing
......................................................................


Patch Set 3:

(1 comment)

I also agree with Josh's comments that it would be nice to see a working example. I think the same logic holds here as with Scott G's chaos debug issue regarding contact URIs. 

If we get to that point and it's NULL, it could be a sign that a larger, systemic issue exists that should be addressed, rather than just treating the symptom.

https://gerrit.asterisk.org/#/c/1192/3//COMMIT_MSG
Commit Message:

Line 7: existance
I just saw this as I was scrolling through code reviews. 

It should be 'existence'. :)


-- 
To view, visit https://gerrit.asterisk.org/1192
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I54079fb94a1440992f4735a9a1bbf1abb1c601ac
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list