[Asterisk-code-review] ARI: Add the ability to subscribe to all events (asterisk[13])

[Ashley Sanders]

Ashley Sanders has posted comments on this change.

Change subject: ARI: Add the ability to subscribe to all events
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/1193/2/res/stasis/app.c
File res/stasis/app.c:

Line 1255: return app_unsubscribe_bridge_id(app, bridge ? bridge->uniqueid : BRIDGE_ALL);
> No, you can't, as in that case bridge will be NULL and we'll dereference a 
Ah, you're right! You could still do:

return app_unsubscribe_bridge_id(app, bridge ? bridge->uniqueid : NULL);

such that the unsubscribe function is the one who determines what the catch-all ID should be. This will reduce the amount of places you would have to modify if the logic surrounding the catch-all ID ever has to be adjusted.


-- 
To view, visit https://gerrit.asterisk.org/1193
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a943b4db24442cf28bc64b24bfd541249790ad6
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes