[Asterisk-code-review] ARI: Add the ability to subscribe to all events (asterisk[13])

[Matt Jordan]

Matt Jordan has posted comments on this change.

Change subject: ARI: Add the ability to subscribe to all events
......................................................................


Patch Set 2:

(4 comments)

https://gerrit.asterisk.org/#/c/1193/2/res/stasis/app.c
File res/stasis/app.c:

Line 1180: return unsubscribe(app, "channel", S_OR(channel_id, CHANNEL_ALL), 0);
> Since unsubscribe can determine from kind and a NULL channel id if the id s
Yup, reverted.


Line 1255: return app_unsubscribe_bridge_id(app, bridge ? bridge->uniqueid : BRIDGE_ALL);
> Since  app_unsubscribe_bridge_id only uses the bridge id for invoking unsub
No, you can't, as in that case bridge will be NULL and we'll dereference a NULL pointer.

The previous case of channel got around that as the function accepts the ID of the channel as a const char *.


Line 1264: return unsubscribe(app, "bridge", S_OR(bridge_id, BRIDGE_ALL), 0);
> Since unsubscribe can determine from kind and a NULL bridge id if the id sh
Yup, this one can be left as NULL.


Line 1356: return unsubscribe(app, "endpoint", S_OR(endpoint_id, ENDPOINT_ALL), 0);
> Since unsubscribe can determine from kind and a NULL endpoint id if the id 
Reverted.


-- 
To view, visit https://gerrit.asterisk.org/1193
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a943b4db24442cf28bc64b24bfd541249790ad6
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes