[Asterisk-code-review] scheduler: Use stack for allocating sched IDs. (asterisk[certified/13.1])

[Mark Michelson]

Mark Michelson has posted comments on this change.

Change subject: scheduler: Use stack for allocating sched IDs.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/1257/1//COMMIT_MSG
Commit Message:

Line 7: scheduler: Use stack for allocating sched IDs.
> Has a public issue been created for this patch?
No. The typical metric for whether a public issue gets created is if there is something user-facing that is being changed in the patch.

This rides a fine line because a user would have no idea there was even a scheduler in Asterisk, much less scheduler IDs. So the idea of fixing an integer overflow is not user-facing. However, the potential consequences of the overflow could be relevant to a user of Asterisk. Since the commit is so focused on the scheduler integer overflow fix and not on any particular consequence, I sided with not creating a public issue for this. If I could point to any one particular crash report or even a particular spot where a crash could occur, I'd open an issue for it. As such, the issue here is, integer overflows, entire system is in an unstable state.


-- 
To view, visit https://gerrit.asterisk.org/1257
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I532708eef8f669d823457d7fefdad9a6078b99b2
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: certified/13.1
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes