[Asterisk-code-review] chan sip.c: Validation on module reload (asterisk[13])
Richard Mudgett
asteriskteam at digium.com
Fri Sep 11 10:47:56 CDT 2015
Richard Mudgett has uploaded a new change for review.
https://gerrit.asterisk.org/1255
Change subject: chan_sip.c: Validation on module reload
......................................................................
chan_sip.c: Validation on module reload
Change validation on reload module because now used the cli function for
reload. The sip_reload() function never fail and ever return NULL for this
reason on reload() now use the call the sip_reload() and return
AST_MODULE_LOAD_SUCCESS.
This problem is dectected on reload by PUT method on ARI, getting always
404 http code when the module is reloaded.
ASTERISK-25325 #close
Reporte by: Rodrigo Ramírez Norambuena
Change-Id: I41215877fb2cfc589e0d4d464000cf6825f4d7fb
---
M channels/chan_sip.c
1 file changed, 2 insertions(+), 4 deletions(-)
git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/55/1255/1
diff --git a/channels/chan_sip.c b/channels/chan_sip.c
index 286386d..cfbc3d3 100644
--- a/channels/chan_sip.c
+++ b/channels/chan_sip.c
@@ -33131,10 +33131,8 @@
/*! \brief Part of Asterisk module interface */
static int reload(void)
{
- if (sip_reload(0, 0, NULL)) {
- return 0;
- }
- return 1;
+ sip_reload(0, 0, NULL);
+ return AST_MODULE_LOAD_SUCCESS;
}
/*! \brief Return the first entry from ast_sockaddr_resolve filtered by address family
--
To view, visit https://gerrit.asterisk.org/1255
To unsubscribe, visit https://gerrit.asterisk.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I41215877fb2cfc589e0d4d464000cf6825f4d7fb
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Rodrigo Ramirez Norambuena <a at rodrigoramirez.com>
More information about the asterisk-code-review
mailing list