[Asterisk-code-review] res pjsip pubsub.c: Set dlg status code instead of sending S... (asterisk[master])

Matt Jordan asteriskteam at digium.com
Thu Sep 10 16:43:31 CDT 2015


Matt Jordan has submitted this change and it was merged.

Change subject: res_pjsip_pubsub.c: Set dlg_status code instead of sending SIP response.
......................................................................


res_pjsip_pubsub.c: Set dlg_status code instead of sending SIP response.

We should not try to send a SIP response message because we may be
restoring a persistent subscription where we are not responding to a SIP
request.

Change-Id: Id89167ef90320c5563f37e632db0dda6cb9e7dec
---
M res/res_pjsip_pubsub.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Mark Michelson: Looks good to me, but someone else must approve
  Anonymous Coward #1000019: Verified
  Matt Jordan: Looks good to me, approved



diff --git a/res/res_pjsip_pubsub.c b/res/res_pjsip_pubsub.c
index 5997640..802bb9e 100644
--- a/res/res_pjsip_pubsub.c
+++ b/res/res_pjsip_pubsub.c
@@ -1263,7 +1263,7 @@
 
 	sub_tree = allocate_subscription_tree(endpoint);
 	if (!sub_tree) {
-		pjsip_endpt_respond_stateless(ast_sip_get_pjsip_endpoint(), rdata, 500, NULL, NULL, NULL);
+		*dlg_status = PJ_ENOMEM;
 		return NULL;
 	}
 	sub_tree->role = AST_SIP_NOTIFIER;

-- 
To view, visit https://gerrit.asterisk.org/1251
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id89167ef90320c5563f37e632db0dda6cb9e7dec
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>



More information about the asterisk-code-review mailing list