[Asterisk-code-review] Scripts: check file versions of Asterisk and dependencies (asterisk[13])

[Mark Michelson]

Mark Michelson has posted comments on this change.

Change subject: Scripts: check file versions of Asterisk and dependencies
......................................................................


Patch Set 3: Code-Review-1

This script seems to make assumptions about locations of various parts of Asterisk. For instance, it assumes that the executable will be in /usr/sbin, and that libdir will be either /usr/lib or /usr/lib64. This is not necessarily going to be the case for people. I think that the script needs to be able to provide a "prefix" option or something similar so that you don't end up triggering false positives on valid installations in non-default directories.

-- 
To view, visit https://gerrit.asterisk.org/1197
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0642d0fb96712476f59760d6d137a24633fe2d6
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Scott Griepentrog <sgriepentrog at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: No