[Asterisk-code-review] pjsip: avoid possible crash req caps allocation failure (asterisk[13])

[Scott Griepentrog]

Scott Griepentrog has posted comments on this change.

Change subject: pjsip: avoid possible crash req_caps allocation failure
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/1215/2/res/res_pjsip_session.c
File res/res_pjsip_session.c:

Line 1300: 	if (!session->req_caps) {
         : 		/* Release the ref held by session->inv_session */
         : 		ao2_ref(session, -1);
         : 	}
> We should return NULL for failure here.
I honestly meant to do that.  Fixing.


-- 
To view, visit https://gerrit.asterisk.org/1215
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I602790ba12714741165e441cc64a3ecde4cb5750
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Scott Griepentrog <sgriepentrog at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Jonathan Rose <jrose at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Scott Griepentrog <sgriepentrog at digium.com>
Gerrit-HasComments: Yes