[Asterisk-code-review] scheduler: Detect and prevent overflow of scheduler IDs. (asterisk[13])

Kevin Harwell asteriskteam at digium.com
Tue Sep 8 13:48:20 CDT 2015


Kevin Harwell has posted comments on this change.

Change subject: scheduler: Detect and prevent overflow of scheduler IDs.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/1218/1/main/sched.c
File main/sched.c:

Line 397: 			tmp->id = con->eventcnt = 0;
Should these be initialized to 1 instead of 0? On creation it looks like it is initially set to 1.


-- 
To view, visit https://gerrit.asterisk.org/1218
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia79fe17ee576edaca5c9cf0f45aaf4d6fdd0e7bb
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list