[Asterisk-code-review] scheduler: Detect and prevent overflow of scheduler IDs. (asterisk[certified/11.6])

Joshua Colp asteriskteam at digium.com
Tue Sep 8 12:03:20 CDT 2015


Joshua Colp has posted comments on this change.

Change subject: scheduler: Detect and prevent overflow of scheduler IDs.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/1217/1/main/sched.c
File main/sched.c:

Line 389: 			tmp->id = con->eventcnt = 0;
We're off in yow'sa land here but... since scheduled items can be rescheduled using the same id - wouldn't this potentially cause scheduled items with the same id?


-- 
To view, visit https://gerrit.asterisk.org/1217
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia79fe17ee576edaca5c9cf0f45aaf4d6fdd0e7bb
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: certified/11.6
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list