[Asterisk-code-review] Makefile: Add rule 'basic-pbx' for installing the Basic PBX ... (asterisk[13])

[Corey Farrell]

Corey Farrell has posted comments on this change.

Change subject: Makefile: Add rule 'basic-pbx' for installing the Basic PBX set of configs
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/1543/2/Makefile
File Makefile:

Line 745: 	$(call INSTALL_CONFIGS,samples,sample)
Would be better to use:
$(call INSTALL_CONFIGS,samples,.sample)

This would allow the INSTALL_CONFIGS macro to be simplified - no tests for -z $(2).


-- 
To view, visit https://gerrit.asterisk.org/1543
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c2e27906f73e2919a2b691da0be20ae70302404
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: David M. Lee <dlee at digium.com>
Gerrit-HasComments: Yes