[Asterisk-code-review] Add the ability to execute the Test Suite against a remote i... (testsuite[master])

[Matt Jordan]

Matt Jordan has posted comments on this change.

Change subject: Add the ability to execute the Test Suite against a remote instance of Asterisk
......................................................................


Patch Set 2:

> I have mixed feelings about how remote Asterisk instances are
 > configured. On the one hand, I like how separating them from the
 > individual test config allows for individuals to tailor their tests
 > to point at whatever Asterisk instance they like. However, having a
 > global set of Asterisk instances seems like it's a recipe for
 > conflict between tests.
 > 
 > I think for this to work, having global remote Asterisk instances
 > is the way to go, but tests that expect to run on remote Asterisk
 > instances will need a way to push configuration to those Asterisk
 > instances on a per-test basis. This way, tests do not have to be
 > aware of each others' assumptions about what extensions/endpoints/etc.
 > exist on any given remote Asterisk instance.

 > I have mixed feelings about how remote Asterisk instances are
 > configured. On the one hand, I like how separating them from the
 > individual test config allows for individuals to tailor their tests
 > to point at whatever Asterisk instance they like. However, having a
 > global set of Asterisk instances seems like it's a recipe for
 > conflict between tests.
 > 
 > I think for this to work, having global remote Asterisk instances
 > is the way to go, but tests that expect to run on remote Asterisk
 > instances will need a way to push configuration to those Asterisk
 > instances on a per-test basis. This way, tests do not have to be
 > aware of each others' assumptions about what extensions/endpoints/etc.
 > exist on any given remote Asterisk instance.

That's an interesting thought. I went with a 'global' approach as - for some set of tests that runs against a known remote system configuration - I figured I wouldn't want to have to specify the same remote system configuration over and over. Plus, I needed something to trigger the Test Suite to behave differently, and the global config felt the most appropriate place.

As it stands today, a custom test object could override the parameters based on its local configuration. You would have to:
a) Call the base class constructor, which sets up the Asterisk instance(s) configuration in self.global_config
b) Update the self.global_config's asterisk-instances key with your test specific settings

Which, if you're at the point of need to customize how the Test Suite connects to a remote instance of Asterisk, is probably not unreasonable.

That being said, I'm open to another way of doing this.

-- 
To view, visit https://gerrit.asterisk.org/1521
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I59a7632e5a1cb38c46484c5035f36993139b7f3f
Gerrit-PatchSet: 2
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: No