[Asterisk-code-review] Adds option to send crash reports via email (testsuite[master])

Corey Farrell asteriskteam at digium.com
Wed Oct 28 11:57:54 CDT 2015


Corey Farrell has posted comments on this change.

Change subject: Adds option to send crash reports via email
......................................................................


Patch Set 4:

(2 comments)

https://gerrit.asterisk.org/#/c/1539/4/runtests.py
File runtests.py:

Line 189:         email_config = load_yaml_config("crash-mail-config.yaml")
Should this file should be listed in .gitignore?


Line 722:                       dest="email_on_crash", default=False,
Might be better if this feature was enabled based on presence or not of crash-mail-config.yaml?


-- 
To view, visit https://gerrit.asterisk.org/1539
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I17def41f15294a48754269d9c42aa649389840ad
Gerrit-PatchSet: 4
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Jonathan Rose <jrose at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jonathan Rose <jrose at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list