[Asterisk-code-review] Testsuite: batched rls subscription failure (testsuite[master])

[Corey Farrell]

Corey Farrell has posted comments on this change.

Change subject: Testsuite: batched rls subscription failure
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

The patch itself looks good, I verified with grep no renames were missed.  I just think the commit message needs to be adjusted so we get more appropriate output from 'git log --oneline'.

https://gerrit.asterisk.org/#/c/1535/1//COMMIT_MSG
Commit Message:

Line 7: Testsuite: batched rls subscription failure
Can we have the first line say that we're renaming the class?  First line should say what the individual commit is doing, not what the series of commits does.  Then the multiline description can explain that it's part of a series, etc.


-- 
To view, visit https://gerrit.asterisk.org/1535
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id2824b92d6925e9717c00872dc20e1a21408aefa
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-HasComments: Yes