[Asterisk-code-review] Add options to send crash reports via email (testsuite[master])

Jonathan Rose asteriskteam at digium.com
Tue Oct 27 11:06:37 CDT 2015


Jonathan Rose has posted comments on this change.

Change subject: Add options to send crash reports via email
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/1539/1/runtests.py
File runtests.py:

Line 729:                       help=("Specify an email server to use for sending crash"
        :                             "reports")
> You don't need () around your help statements.
Parenthesis are the currently precedented way to write a long help statement though; option --test for example.

Should I favor matching the existing format or should I go with concatenating with + like you suggested for combining the email contents?


-- 
To view, visit https://gerrit.asterisk.org/1539
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I17def41f15294a48754269d9c42aa649389840ad
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Jonathan Rose <jrose at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Jonathan Rose <jrose at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list