[Asterisk-code-review] pjsip/subscriptions/nat notify: Fix test after pubsub changes (testsuite[master])

Joshua Colp asteriskteam at digium.com
Mon Oct 26 15:30:58 CDT 2015


Joshua Colp has submitted this change and it was merged.

Change subject: pjsip/subscriptions/nat_notify: Fix test after pubsub changes
......................................................................


pjsip/subscriptions/nat_notify: Fix test after pubsub changes

Recent pubsub changes made the ordering of SIP messages more
predictable and sane. This test did not get updated to take this
into account. This change does so.

Change-Id: Ic0423b888d3545794f42fd7817f930732bb387b3
---
M tests/channels/pjsip/subscriptions/nat_notify/sipp/subscribe.xml
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Richard Mudgett: Looks good to me, but someone else must approve
  Anonymous Coward #1000019: Verified
  Joshua Colp: Looks good to me, approved



diff --git a/tests/channels/pjsip/subscriptions/nat_notify/sipp/subscribe.xml b/tests/channels/pjsip/subscriptions/nat_notify/sipp/subscribe.xml
index fc9f6d0..5eb7d3a 100644
--- a/tests/channels/pjsip/subscriptions/nat_notify/sipp/subscribe.xml
+++ b/tests/channels/pjsip/subscriptions/nat_notify/sipp/subscribe.xml
@@ -86,10 +86,10 @@
     ]]>
   </send>
 
+  <recv response="200" crlf="true" />
+
   <!-- NOTIFY upon resubscription -->
   <recv request="NOTIFY" crlf="true" />
-
-  <recv response="200" crlf="true" />
 
   <send>
     <![CDATA[

-- 
To view, visit https://gerrit.asterisk.org/1538
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic0423b888d3545794f42fd7817f930732bb387b3
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>



More information about the asterisk-code-review mailing list